Fix UB in EvalScript #1212
Merged
Fix UB in EvalScript #1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levonpetrosyan93
approved these changes
Dec 6, 2022
levonpetrosyan93
pushed a commit
that referenced
this pull request
May 17, 2023
* Do not construct out-of-bound pointers in SHA512/SHA1/RIPEMD160 code * Fix UB resulting from a bad pointer construction in CSHA256::Write. Co-authored-by: Pieter Wuille <pieter.wuille@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR intention
Fix UB in EvalScript.
Code changes brief
Prevent the construction of pointers offset from nullptr.